7:39 a.m.
Post via forum by datahead <cjj_009@xxxxxxxxxx>:
Was the Apple code in main.cpp simply removed in the SFML port branch? This code is
present in devel.
This was code within:
[code]
#ifdef __APPLE__
[/code]
Did the code serve no purpose, or are we just not sure that it will work at all if someone
ports to Apple?
We probably will eventually port TSC to an Apple dev environment, so we'd want to make
sure we provide as many resources as possible.
--
Sent by Chessboard.
8 a.m.
datahead <automailer(a)forum.secretchronicles.de> writes:
Post via forum by datahead <cjj_009@xxxxxxxxxx>:
Was the Apple code in main.cpp simply removed in the SFML port branch? This code is
present in devel.
This was code within:
[code]
#ifdef __APPLE__
[/code]
The code that determined the resource path on Apple systems is probably
unnecessary anyway, because with the rework of the ResourceManager for
2.0.0 the data path is determined relative to the executable (or by
compilation option). I would expect that to work on Apple systems as
well, so I think that code can be removed anyway.
Did the code serve no purpose, or are we just not sure that it will
work at all if someone ports to Apple?
That’s it. I don’t know exactly what it does, and I have no possibility
to determine that. Since main.cpp is a file one views rather seldom, I
finally forget about its presence. You will need to ask a Mac developer
on whether he needs it. Fact is that TSC runs fine without it on
non-Apple systems.
We probably will eventually port TSC to an Apple dev environment, so
we'd want to make sure we provide as many resources as possible.
You can always retrieve the code from Git’s history again, so there is
no loss in deleting it.
Vale,
Quintus
--
#!/sbin/quintus
Blog: http://www.guelkerdev.de
GnuPG key: F1D8799FBCC8BC4F
8:56 a.m.
Post via forum by datahead <cjj_009@xxxxxxxxxx>:
[quote]The code that determined the resource path on Apple systems is probably
unnecessary anyway, because with the rework of the ResourceManager for
2.0.0 the data path is determined relative to the executable (or by
compilation option). I would expect that to work on Apple systems as
well, so I think that code can be removed anyway.[/quote]
If we have every reason to believe that Apple systems should be able to find the resources
due to our ResourceManager changes, I think this makes sense. I am not quite as familiar
with this sub system, so I'll take your advice.
[quote]Fact is that TSC runs fine without it on non-Apple systems.[/quote]
[quote]You can always retrieve the code from Git’s history again, so there is
no loss in deleting it.[/quote]
I'd be a little cautious with this mindset, since cross platform support has always
been one of our tenets. We've already lost about 1 or 2 potential contributors due to
a lack of Mac compilation support. Visual Studio likewise could bring in new developers.
I realize, of course, that we will not have Visual Studio support for quite a while due to
the technical issues we saw last time we tried.
It actually can be a little bit of trouble to find useful code in older versions of git
history. Most people will simply use the most recent version. As I said above, I think
it is fine to remove the code in this case, though.
--
Sent by Chessboard.
5:24 p.m.
datahead <automailer(a)forum.secretchronicles.de> writes:
If we have every reason to believe that Apple systems should be able
to find the resources due to our ResourceManager changes, I think this
makes sense. I am not quite as familiar with this sub system, so I'll
take your advice.
It just looks where the “tsc” executable is located (using an
OS-specific syscall) and then searches the directories relative to that
file. This is something I would say works on Apple systems the same way
as on other systems. The only thing that is missing is the OS-specific
syscall in the resource manager to make this work (if you tried to
compile on Apple, you’d get blown out by a preprocessor #error directive
signalling that you must implement the function returning the path to
the “tsc” executable for that OS first).
In case you wonder, I have protected all OS-specific functions in TSC
with #error lines. This allows someone who wants to port TSC to another
platform to spot very easily the points where OS-specific code is
required. All of these spots are marked with an #error directive that
will stop the compilation once encountered.
Vale,
Quintus
--
#!/sbin/quintus
Blog: http://www.guelkerdev.de
GnuPG key: F1D8799FBCC8BC4F
1953
days inactive
1954
days old
tsc-devel@lists.secretchronicles.org
3 comments
2 participants
participants (2)
-
datahead -
Quintus